MIME-Version: 1.0
In-Reply-To: <20150430173659.GA30177@bshelton-desktop>
References: <1430335682-6174-1-git-send-email-ben.shelton@ni.com>
 <20150429214648.GF32500@ld-irv-0074> <20150430173659.GA30177@bshelton-desktop>
From: Jonas Gorski <jogo@openwrt.org>
Date: Fri, 1 May 2015 13:57:13 +0200
Message-ID: <CAOiHx==fAPcji2=zjmO+m6yBX1xgB83XQk4+WgYgop=L4uZq7Q@mail.gmail.com>
Subject: Re: [PATCH] mtd: Introduce CONFIG_MTD_RESERVE_END
To: Ben Shelton <ben.shelton@ni.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
        MTD Maling List <linux-mtd@lists.infradead.org>,
        David Woodhouse <dwmw2@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jeff Westfahl <jeff.westfahl@ni.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1106
Lines: 24

On Thu, Apr 30, 2015 at 7:36 PM, Ben Shelton <ben.shelton@ni.com> wrote:
> The reason for doing this as a Kconfig option rather than with an additional
> partition is that we use the same .itb boot image (and kernel arguments) for
> a series of embedded controllers that have different NAND flash sizes, and we
> use the '-' command line parameter to give the root partition all the available
> space after the other partitions.

Wouldn't it make more sense to make cmdlineparts to recognize if it is
run on a nand flash that has on-flash BBT enabled, and then reduce the
SIZE_REMAINING partition's size by the amount of nand_bbt_descr's
maxblocks * erase block size?

Currently your proposed solution would break if boards have differing
erase block sizes, or if some have NOR flash, which makes it an option
for a rather narrow use case IMHO.


Regards
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/