Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753864AbbEAOCm (ORCPT ); Fri, 1 May 2015 10:02:42 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45737 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753543AbbEAOCk (ORCPT ); Fri, 1 May 2015 10:02:40 -0400 Date: Fri, 1 May 2015 15:02:25 +0100 From: Mark Brown To: Belisko Marek Cc: perex@perex.cz, tiwai@suse.de, "Dr. H. Nikolaus Schaller" , "devicetree@vger.kernel.org" , LKML , alsa-devel@alsa-project.org Message-ID: <20150501140225.GY22845@sirena.org.uk> References: <1430429283-27907-1-git-send-email-marek@goldelico.com> <1430429283-27907-2-git-send-email-marek@goldelico.com> <20150501110311.GV22845@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l9OvbEp/JYZ/p+uv" Content-Disposition: inline In-Reply-To: X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/3] ASoC: Add gtm601 codec driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 47 --l9OvbEp/JYZ/p+uv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 01, 2015 at 01:36:48PM +0200, Belisko Marek wrote: > On Fri, May 1, 2015 at 1:03 PM, Mark Brown wrote: > > On Thu, Apr 30, 2015 at 11:28:01PM +0200, Marek Belisko wrote: > >> +/* > >> + * Note this is a simple chip with no configuration interface, sample rate is > >> + * determined automatically by examining the Master clock and Bit clock ratios > >> + */ > > > >> +#define GTM601_RATES (SNDRV_PCM_RATE_8000) > > Does it or doesn't it support multiple sample rates? > It support only 8kHz rate. I'll remove define and use SNDRV_PCM_RATE_8000 > only in gtm601_dai struct. I was more commenting on the fact that the comment immediately above says that the sample rate is determined automatically which suggests that multiple sample rates are supported. --l9OvbEp/JYZ/p+uv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVQ4dwAAoJECTWi3JdVIfQ0noH/0aGUH8Q/GvQmW9609Zzeqhz LQovDqAiFPx8VQRAeB96LVYUdiTC6BBnKFy+b434VQ41NScxS07sPo7ypDVNWDBd pwBoLCbJC/xeUVw1tZO4rvIuWJApzD7XukhqgDUK3JZcX7qqaZ61QdteeXr7Nrhn 4RUiamPqmfS0HCViugGUmMp+P22Y4W48LmqJmIjKm+J54nZOZ5LQaNp731sIc2SK i4U9eQI9cjqFnOGgRJ+2o2xj69hxVTSW3Z3LyySSB9FbXbq8xVeX+FRjOM7IuEji c64laBuQXPSSTbmOF/wqspv6tHPH3M6M+ql6Ihpfkd8fMQoCN6gFMWhvC6FfICQ= =WdGS -----END PGP SIGNATURE----- --l9OvbEp/JYZ/p+uv-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/