Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753895AbbEAPBW (ORCPT ); Fri, 1 May 2015 11:01:22 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:35709 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753624AbbEAPBU (ORCPT ); Fri, 1 May 2015 11:01:20 -0400 MIME-Version: 1.0 In-Reply-To: <1430469241-30556-1-git-send-email-fabf@skynet.be> References: <1430469241-30556-1-git-send-email-fabf@skynet.be> Date: Fri, 1 May 2015 20:31:19 +0530 Message-ID: Subject: Re: [PATCH V3 1/2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure From: Viresh Kumar To: Fabian Frederick Cc: Linux Kernel Mailing List , Joe Perches , "Rafael J. Wysocki" , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 908 Lines: 24 On 1 May 2015 at 14:04, Fabian Frederick wrote: > typedef is not really useful here. Replace it by structure > to improve readability. typedef should only be used in some cases. > (See Documentation/CodingStyle Chapter 5 for details). > > Signed-off-by: Fabian Frederick > --- > Compiled but untested. > > V3: -constify arrays(patch 2) (suggested by Joe Perches) > -fix typo in changelog (thanks to Viresh Kumar) > V2: -verbose changelog. > > drivers/cpufreq/pxa2xx-cpufreq.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) For both patches: Acked-by: Viresh Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/