Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754004AbbEAPJ6 (ORCPT ); Fri, 1 May 2015 11:09:58 -0400 Received: from mga02.intel.com ([134.134.136.20]:64589 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753650AbbEAPJ5 (ORCPT ); Fri, 1 May 2015 11:09:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,350,1427785200"; d="scan'208";a="703840311" Message-ID: <55439734.1070709@linux.intel.com> Date: Fri, 01 May 2015 08:09:40 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Aravind Gopalakrishnan , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tony.luck@intel.com, bp@alien8.de, jiang.liu@linux.intel.com, yinghai@kernel.org CC: x86@kernel.org, dvlasenk@redhat.com, JBeulich@suse.com, slaoub@gmail.com, luto@amacapital.net, oleg@redhat.com, rostedt@goodmis.org, rusty@rustcorp.com.au, prarit@redhat.com, linux@rasmusvillemoes.dk, jroedel@suse.de, andriy.shevchenko@linux.intel.com, macro@linux-mips.org, wangnan0@huawei.com, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH 1/4] x86/mce: Define 'SUCCOR' cpuid bit References: <1430405365-4473-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1430405365-4473-2-git-send-email-Aravind.Gopalakrishnan@amd.com> In-Reply-To: <1430405365-4473-2-git-send-email-Aravind.Gopalakrishnan@amd.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 18 On 04/30/2015 07:49 AM, Aravind Gopalakrishnan wrote: > @@ -1640,6 +1640,7 @@ static void __mcheck_cpu_init_vendor(struct cpuinfo_x86 *c) > case X86_VENDOR_AMD: > mce_amd_feature_init(c); > mce_flags.overflow_recov = cpuid_ebx(0x80000007) & 0x1; > + mce_flags.succor = (cpuid_ebx(0x80000007) & 0x2) ? 1 : 0; > break; > default: > break; Is there a reason to add the cpuid detection like this instead of adding an X86_FEATURE_ for it and using cpu_has() and friends? Doing that would also let you see the bit in /proc/cpuinfo. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/