Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751429AbbEARLb (ORCPT ); Fri, 1 May 2015 13:11:31 -0400 Received: from verein.lst.de ([213.95.11.211]:56073 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbEARL2 (ORCPT ); Fri, 1 May 2015 13:11:28 -0400 Date: Fri, 1 May 2015 19:11:26 +0200 From: Christoph Hellwig To: Shaohua Li Cc: linux-kernel@vger.kernel.org, axboe@fb.com, jmoyer@redhat.com, hch@lst.de, neilb@suse.de Subject: Re: [PATCH 1/5] blk: clean up plug Message-ID: <20150501171126.GA16920@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 15 On Thu, Apr 30, 2015 at 10:45:14AM -0700, Shaohua Li wrote: > Current code looks like inner plug gets flushed with a > blk_finish_plug(). Actually it's a nop. All requests/callbacks are added > to current->plug, while only outmost plug is assigned to current->plug. > So inner plug always has empty request/callback list, which makes > blk_flush_plug_list() a nop. This tries to make the code more clear. Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/