Date: Fri, 1 May 2015 19:14:10 +0200
From: Christoph Hellwig <hch@lst.de>
To: Shaohua Li <shli@fb.com>
Cc: linux-kernel@vger.kernel.org, axboe@fb.com, jmoyer@redhat.com, hch@lst.de,
        neilb@suse.de
Subject: Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in
	io_schedule_out
Message-ID: <20150501171410.GB16920@lst.de>
References: <cover.1430414609.git.shli@fb.com> <9eedafbfb33bf3e8d273860e75f9f07ca9b0d5ec.1430414610.git.shli@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9eedafbfb33bf3e8d273860e75f9f07ca9b0d5ec.1430414610.git.shli@fb.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 941
Lines: 29

On Thu, Apr 30, 2015 at 10:45:15AM -0700, Shaohua Li wrote:
>  long __sched io_schedule_timeout(long timeout)
>  {
> -	int old_iowait = current->in_iowait;
>  	struct rq *rq;
>  	long ret;
>  
>  	current->in_iowait = 1;
> -	if (old_iowait)
> -		blk_schedule_flush_plug(current);
> -	else
> -		blk_flush_plug(current);
> +	blk_schedule_flush_plug(current);
>  
>  	delayacct_blkio_start();
>  	rq = raw_rq();
>  	atomic_inc(&rq->nr_iowait);
>  	ret = schedule_timeout(timeout);
> -	current->in_iowait = old_iowait;
> +	current->in_iowait = 0;

Always clearing ->in_iowait is behavior change not mentioned in the
changelog.  Even if it was intentional it would better be done in
a separate patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/