Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbbEARQ7 (ORCPT ); Fri, 1 May 2015 13:16:59 -0400 Received: from verein.lst.de ([213.95.11.211]:56089 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbEARQ6 (ORCPT ); Fri, 1 May 2015 13:16:58 -0400 Date: Fri, 1 May 2015 19:16:56 +0200 From: Christoph Hellwig To: Shaohua Li Cc: linux-kernel@vger.kernel.org, axboe@fb.com, jmoyer@redhat.com, hch@lst.de, neilb@suse.de Subject: Re: [PATCH 3/5] blk-mq: fix plugging in blk_sq_make_request Message-ID: <20150501171656.GC16920@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 502 Lines: 11 > - if (use_plug && !blk_queue_nomerges(q) && > + if (likely(!is_flush_fua) && !blk_queue_nomerges(q) && Please don't sprinkle likely annotations for no go reason. Especially on metadata write heavy workloads (e.g. an NFS server) it might be very likely. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/