Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751459AbbEAR10 (ORCPT ); Fri, 1 May 2015 13:27:26 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34058 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbbEAR1Y (ORCPT ); Fri, 1 May 2015 13:27:24 -0400 Message-ID: <5543B779.8040109@codeaurora.org> Date: Fri, 01 May 2015 11:27:21 -0600 From: Jeffrey Hugo User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Lina Iyer , ohad@wizery.com, s-anna@ti.com, Bjorn.Andersson@sonymobile.com, agross@codeaurora.org CC: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, galak@codeaurora.org Subject: Re: [PATCH] hwspinlock: qcom: Lock #7 is special lock, uses dynamic proc_id References: <1430499992-47944-1-git-send-email-lina.iyer@linaro.org> In-Reply-To: <1430499992-47944-1-git-send-email-lina.iyer@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1143 Lines: 32 On 5/1/2015 11:06 AM, Lina Iyer wrote: > diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c > index 93b62e0..043c62c 100644 > --- a/drivers/hwspinlock/qcom_hwspinlock.c > +++ b/drivers/hwspinlock/qcom_hwspinlock.c > @@ -25,16 +25,26 @@ > > #include "hwspinlock_internal.h" > > -#define QCOM_MUTEX_APPS_PROC_ID 1 > -#define QCOM_MUTEX_NUM_LOCKS 32 > +#define QCOM_MUTEX_APPS_PROC_ID 1 > +#define QCOM_MUTEX_CPUIDLE_OFFSET 128 > +#define QCOM_CPUIDLE_LOCK 7 > +#define QCOM_MUTEX_NUM_LOCKS 32 > + This part of the diff doesn't look right. Why is it showing that QCOM_MUTEX_APPS_PROC_ID and QCOM_MUTEX_NUM_LOCKS are deleted and added lines? Shouldn't they be unchanged by this patch? -- Jeffrey Hugo Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/