Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751149AbbEARbW (ORCPT ); Fri, 1 May 2015 13:31:22 -0400 Received: from mail-ig0-f174.google.com ([209.85.213.174]:33079 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbEARbT (ORCPT ); Fri, 1 May 2015 13:31:19 -0400 Date: Fri, 1 May 2015 11:31:17 -0600 From: Lina Iyer To: Jeffrey Hugo Cc: ohad@wizery.com, s-anna@ti.com, Bjorn.Andersson@sonymobile.com, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, galak@codeaurora.org Subject: Re: [PATCH] hwspinlock: qcom: Lock #7 is special lock, uses dynamic proc_id Message-ID: <20150501173117.GA7115@linaro.org> References: <1430499992-47944-1-git-send-email-lina.iyer@linaro.org> <5543B779.8040109@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <5543B779.8040109@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 40 On Fri, May 01 2015 at 11:27 -0600, Jeffrey Hugo wrote: >On 5/1/2015 11:06 AM, Lina Iyer wrote: > >>diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c >>index 93b62e0..043c62c 100644 >>--- a/drivers/hwspinlock/qcom_hwspinlock.c >>+++ b/drivers/hwspinlock/qcom_hwspinlock.c >>@@ -25,16 +25,26 @@ >> >> #include "hwspinlock_internal.h" >> >>-#define QCOM_MUTEX_APPS_PROC_ID 1 >>-#define QCOM_MUTEX_NUM_LOCKS 32 >>+#define QCOM_MUTEX_APPS_PROC_ID 1 >>+#define QCOM_MUTEX_CPUIDLE_OFFSET 128 >>+#define QCOM_CPUIDLE_LOCK 7 >>+#define QCOM_MUTEX_NUM_LOCKS 32 >>+ > >This part of the diff doesn't look right. Why is it showing that >QCOM_MUTEX_APPS_PROC_ID and QCOM_MUTEX_NUM_LOCKS are deleted and added >lines? Shouldn't they be unchanged by this patch? > Sigh. I must have updated the tabs to play nice. Will fix in the next spin. Thanks for the review. --Lina >-- >Jeffrey Hugo >Qualcomm Innovation Center, Inc. >The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/