Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751252AbbEAStB (ORCPT ); Fri, 1 May 2015 14:49:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40870 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbbEASs7 (ORCPT ); Fri, 1 May 2015 14:48:59 -0400 Message-ID: <1430506137.4472.262.camel@redhat.com> Subject: Re: [GIT PULL] VFIO fixes for v4.1-rc2 From: Alex Williamson To: Linus Torvalds Cc: Oleg Nesterov , linux-kernel , kvm Date: Fri, 01 May 2015 12:48:57 -0600 In-Reply-To: References: <1430502057.4472.255.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1452 Lines: 33 On Fri, 2015-05-01 at 11:37 -0700, Linus Torvalds wrote: > On Fri, May 1, 2015 at 10:40 AM, Alex Williamson > wrote: > > > > - Flush signals on interrupted wait to retain polling interval (Alex Williamson) > > This cannot *possibly* be right. If I read this patch right, you're > randomly just getting rid of signals. No way in hell is that correct. > > "flush_signals()" is only for kernel threads, where it's a hacky > alternative to actually handling them (since kernel threads never > rreturn to user space and cannot really "handle" a signal). But you're > doing it in the ->remove handler for the device, which can be called > by arbitrary system processes. This is not a kernel thread thing, as > far as I can see. > > If you cannot handle signals, you damn well shouldn't be using > "wait_event_interruptible_timeout()" to begin with. Get rid of the > "interruptible", since it apparently *isn't* interruptible. > > So I'm not pulling this. Ok. It seemed like useful behavior to be able to provide some response to the user in the event that a ->remove handler is blocked by a device in-use and the user attempts to abort the action. Thanks for reviewing, Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/