Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbbEAThT (ORCPT ); Fri, 1 May 2015 15:37:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40907 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbbEAThR (ORCPT ); Fri, 1 May 2015 15:37:17 -0400 From: Jeff Moyer To: Shaohua Li Cc: , , , Subject: Re: [PATCH 2/5] sched: always use blk_schedule_flush_plug in io_schedule_out References: <9eedafbfb33bf3e8d273860e75f9f07ca9b0d5ec.1430414610.git.shli@fb.com> <20150501182807.GA2041646@devbig257.prn2.facebook.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 01 May 2015 15:37:09 -0400 In-Reply-To: <20150501182807.GA2041646@devbig257.prn2.facebook.com> (Shaohua Li's message of "Fri, 1 May 2015 11:28:07 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 35 Shaohua Li writes: > V2: don't change ->in_iowait > > Cc: NeilBrown > Signed-off-by: Shaohua Li > --- > kernel/sched/core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index f9123a8..1ab3d2d 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -4402,10 +4402,7 @@ long __sched io_schedule_timeout(long timeout) > long ret; > > current->in_iowait = 1; > - if (old_iowait) > - blk_schedule_flush_plug(current); > - else > - blk_flush_plug(current); > + blk_schedule_flush_plug(current); > > delayacct_blkio_start(); > rq = raw_rq(); Looks good to me. Reviewed-by: Jeff Moyer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/