Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752449AbbEAUwk (ORCPT ); Fri, 1 May 2015 16:52:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:28907 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbbEAUwi convert rfc822-to-8bit (ORCPT ); Fri, 1 May 2015 16:52:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,352,1427785200"; d="scan'208";a="703983124" From: "Drokin, Oleg" To: Greg Kroah-Hartman CC: "Simmons, James A." , Dan Carpenter , "devel@driverdev.osuosl.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Julia Lawall , "HPDD-discuss@lists.01.org" Subject: Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree Thread-Topic: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree Thread-Index: AQHQhEnF1Z60vF9Ok063U3coNmW0Gp1oCamAgAADvwCAAADeAA== Date: Fri, 1 May 2015 20:52:37 +0000 Message-ID: References: <1430495482-933-1-git-send-email-Julia.Lawall@lip6.fr> <1430495482-933-11-git-send-email-Julia.Lawall@lip6.fr> <20150501200221.GF14154@mwanda> <9f81478864bc422c9a59cddbaa723052@EXCHCS32.ornl.gov> <20150501204930.GB2265@kroah.com> In-Reply-To: <20150501204930.GB2265@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.199.128] Content-Type: text/plain; charset="us-ascii" Content-ID: <0022705979C7484CACC9E8D044433BF3@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 41 On May 1, 2015, at 4:49 PM, Greg Kroah-Hartman wrote: > On Fri, May 01, 2015 at 08:36:05PM +0000, Simmons, James A. wrote: >>> We are hopefully going to get rid of OBD_ALLOC_LARGE() as well, though. >>> >>> It's simple enough to write a function: >>> >>> void *obd_zalloc(size_t size) >>> { >>> if (size > 4 * PAGE_CACHE_SIZE) >>> return vzalloc(size); >>> else >>> return kmalloc(size, GFP_NOFS); >>> } >>> >>> Except, huh? Shouldn't we be using GFP_NOFS for the vzalloc() side? >>> There was some discussion of that GFP_NOFS was a bit buggy back in 2010 >>> (http://marc.info/?l=linux-mm&m=128942194520631&w=4) but the current >>> lustre code doesn't try to pass GFP_NOFS. >> >> The version in the upstream client is out of date. The current macro in the Intel master >> Branch is: > > That's not helpful at all, why do we even have an in-kernel version of > this code if you don't do your development in the kernel? > > Please sync with the kernel tree very soon, or I'm just going to delete > this whole thing. This is getting _really_ frustrating. The patch was submitted. But it depends on a symbol that's not exported. I was not able to change that. http://www.spinics.net/lists/linux-mm/msg83997.html Bye, Oleg-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/