Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751120AbbEAW5t (ORCPT ); Fri, 1 May 2015 18:57:49 -0400 Received: from mta02.ornl.gov ([128.219.177.12]:26793 "EHLO mta02.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbbEAW5r convert rfc822-to-8bit (ORCPT ); Fri, 1 May 2015 18:57:47 -0400 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.13,353,1427774400"; d="scan'208";a="79402300" From: "Simmons, James A." To: "'Greg Kroah-Hartman'" CC: "'Julia Lawall'" , "devel@driverdev.osuosl.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Oleg Drokin , "HPDD-discuss@lists.01.org" Subject: RE: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree Thread-Topic: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree Thread-Index: AQHQhDcGSjuySU6k/EC2FSAoAQR6Jp1njMlQgABN6oD//97EkA== Date: Fri, 1 May 2015 22:57:45 +0000 Message-ID: References: <1430495482-933-1-git-send-email-Julia.Lawall@lip6.fr> <1430495482-933-11-git-send-email-Julia.Lawall@lip6.fr> <524505df3433441494cf082a425f2ee7@EXCHCS32.ornl.gov> <20150501204729.GA2265@kroah.com> In-Reply-To: <20150501204729.GA2265@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 16 >> Yes the LARGE functions do the switching. I was expecting also patches to remove the >> OBD_ALLOC_LARGE functions as well which is not the case here. I do have one question still. The >> macro __OBD_MALLOC_VERBOSE allowed the ability to simulate memory allocation failures at >> a certain percentage rate. Does something exist in the kernel to duplicate that functionality? > >Yes, no need for lustre to duplicate yet-another-thing the kernel >already provides :) The reason for this is that libcfs was written 10+ years ago which was before linux had such nice features. At that time it was needed to fill the gaps missing which is no longer the case. Libcfs is really showing its age :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/