Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751267AbbEAW66 (ORCPT ); Fri, 1 May 2015 18:58:58 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:39139 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbbEAW64 (ORCPT ); Fri, 1 May 2015 18:58:56 -0400 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: omap4iss: Constify platform_device_id Date: Sat, 02 May 2015 01:59:18 +0300 Message-ID: <5656464.AXyQi80ZiG@avalon> User-Agent: KMail/4.14.3 (Linux/3.18.11-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1430494987-31013-1-git-send-email-k.kozlowski.k@gmail.com> References: <1430494987-31013-1-git-send-email-k.kozlowski.k@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1246 Lines: 43 Hi Krzysztof, Thank you for the patch. On Saturday 02 May 2015 00:43:07 Krzysztof Kozlowski wrote: > The platform_device_id is not modified by the driver and core uses it as > const. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Laurent Pinchart and applied to my tree. I'll send a pull request for v4.2. > --- > drivers/staging/media/omap4iss/iss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/omap4iss/iss.c > b/drivers/staging/media/omap4iss/iss.c index e0ad5e520e2d..68867f286afd > 100644 > --- a/drivers/staging/media/omap4iss/iss.c > +++ b/drivers/staging/media/omap4iss/iss.c > @@ -1478,7 +1478,7 @@ static int iss_remove(struct platform_device *pdev) > return 0; > } > > -static struct platform_device_id omap4iss_id_table[] = { > +static const struct platform_device_id omap4iss_id_table[] = { > { "omap4iss", 0 }, > { }, > }; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/