Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751031AbbEAXHQ (ORCPT ); Fri, 1 May 2015 19:07:16 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:39148 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbbEAXHO (ORCPT ); Fri, 1 May 2015 19:07:14 -0400 From: Laurent Pinchart To: Nicholas Mc Guire Cc: David Woodhouse , Brian Norris , Vinod Koul , Laurent Pinchart , Kuninori Morimoto , Wolfram Sang , Arnd Bergmann , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mtd: sh_flctl: remove unused variable and assignment Date: Sat, 02 May 2015 02:07:37 +0300 Message-ID: <2084504.Aj3JxUhj5c@avalon> User-Agent: KMail/4.14.3 (Linux/3.18.11-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1430489763-18417-3-git-send-email-hofrat@osadl.org> References: <1430489763-18417-1-git-send-email-hofrat@osadl.org> <1430489763-18417-3-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2032 Lines: 63 Hi Nicholas, Thank you for the patch. On Friday 01 May 2015 16:16:03 Nicholas Mc Guire wrote: > Fixes a compile warning [-Wunused-but-set-variable] only. > > Signed-off-by: Nicholas Mc Guire > --- > > This fixes the compile time warning: > drivers/mtd/nand/sh_flctl.c: In function 'flctl_dma_fifo0_transfer': > drivers/mtd/nand/sh_flctl.c:354:15: warning: variable 'cookie' set but not > used [-Wunused-but-set-variable] > > as dmaengine_submit only reads and returns desc->tx_submit(desc) which > is then unused in flctl_dma_fifo0_transfer, this should be side-effect > free to remove. You can ignore its return value, but you can't remove the call to dmaengine_submit, as it's part of the DMA engine API and desc->tx_submit() does important work. > Patch was compile tested with ap325rxa_defconfig (implies > CONFIG_MTD_NAND_SH_FLCTL=y) > > Patch is against 4.1-rc1 (localversion-next is -next-20150501) > > drivers/mtd/nand/sh_flctl.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index b9f265a..6a5c4f7 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -351,7 +351,6 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl > *flctl, unsigned long *buf, struct dma_chan *chan; > enum dma_transfer_direction tr_dir; > dma_addr_t dma_addr; > - dma_cookie_t cookie = -EINVAL; > uint32_t reg; > int ret; > unsigned long time_left; > @@ -377,7 +376,6 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl > *flctl, unsigned long *buf, > > desc->callback = flctl_dma_complete; > desc->callback_param = flctl; > - cookie = dmaengine_submit(desc); > > dma_async_issue_pending(chan); > } else { -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/