Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751319AbbEBEMv (ORCPT ); Sat, 2 May 2015 00:12:51 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:33550 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbbEBEMs (ORCPT ); Sat, 2 May 2015 00:12:48 -0400 MIME-Version: 1.0 In-Reply-To: <1430516505-4812-1-git-send-email-aricart@memnix.com> References: <1430516505-4812-1-git-send-email-aricart@memnix.com> Date: Fri, 1 May 2015 21:12:47 -0700 X-Google-Sender-Auth: DKvP4nIxw9zYQtB6YTi_NDIX4u8 Message-ID: Subject: Re: [PATCH] MODSIGN: Change default key details [ver #2] From: Linus Torvalds To: Abelardo Ricart III , Michal Marek Cc: Linux Kernel Mailing List , Sedat Dilek , David Howells , keyrings@linux-nfs.org, Rusty Russell , LSM List , James Morris , Greg Kroah-Hartman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 37 On Fri, May 1, 2015 at 2:41 PM, Abelardo Ricart III wrote: > > Here's my two-line patch strictly defining the build order, for your perusal. Ok, so this looks possible and sounds like it could explain the issues. But I'd like somebody who is much more familiar with these kinds of subtleties in 'make' to take anothe rlook and ack it. Because I had personally never even heard (much less used) about these magical GNU make "order-only prerequisites". Live and learn. > -signing_key.priv signing_key.x509: x509.genkey > +signing_key.priv signing_key.x509: | x509.genkey > + $(warning *** X.509 module signing key pair not found in root of source tree ***) So we shouldn't warn about this. The "generate random key" should be the normal action for just about everybody but actual preduction vendor builds. It's definitely not an error condition. But that ": |" syntax is interesting. I quick grep does show that we do have a few previous uses, so I guess we really *do* use just about every possible feature of GNU make even if I wasn't aware of this one.. The "generate random key" does seem to be a similar "prep" phase as the __dtbs_install_prep thing we do in the dtb install. Adding Michal Marek to the cc, since I want an Ack from somebody who knows the details of GNU make more than I do. Anybody else who is a makefile God? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/