Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751564AbbEBQah (ORCPT ); Sat, 2 May 2015 12:30:37 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:36913 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbbEBQae (ORCPT ); Sat, 2 May 2015 12:30:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <1429781325-6177-1-git-send-email-firogm@gmail.com> Date: Sat, 2 May 2015 09:30:34 -0700 X-Google-Sender-Auth: gNvAT2bx9rYoRixY0kIw-NdDx3g Message-ID: Subject: Re: [PATCH] hpfs: Remove unessary cast From: Linus Torvalds To: Mikulas Patocka Cc: Linux Kernel Mailing List , Firo Yang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 44 Mikulas, when forwarding patches from others, you also need to add that "From: Firo Yang " at the top (and it can be nice if you also add the date-line). Otherwise authorship gets lost. Sign-off lines _normally_ show the whole authorship chain too, but no, it's not enough to just have the sign-off line there. Linus On Sat, May 2, 2015 at 1:10 AM, Mikulas Patocka wrote: > Avoid a pointless kmem_cache_alloc() return value cast in > fs/hpfs/super.c::hpfs_alloc_inode() > > Signed-off-by: Firo Yang > Acked-by: Mikulas Patocka > > > --- > fs/hpfs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c > index 7cd00d3..ccace08 100644 > --- a/fs/hpfs/super.c > +++ b/fs/hpfs/super.c > @@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep; > static struct inode *hpfs_alloc_inode(struct super_block *sb) > { > struct hpfs_inode_info *ei; > - ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, > GFP_NOFS); > + ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS); > if (!ei) > return NULL; > ei->vfs_inode.i_version = 1; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/