Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945999AbbEBTW0 (ORCPT ); Sat, 2 May 2015 15:22:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45093 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945977AbbEBTWV (ORCPT ); Sat, 2 May 2015 15:22:21 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Charles Keepax , Beata Michalska , Wolfram Sang Subject: [PATCH 4.0 187/220] i2c: Mark adapter devices with pm_runtime_no_callbacks Date: Sat, 2 May 2015 21:01:42 +0200 Message-Id: <20150502185902.390578789@linuxfoundation.org> X-Mailer: git-send-email 2.3.7 In-Reply-To: <20150502185854.333748961@linuxfoundation.org> References: <20150502185854.333748961@linuxfoundation.org> User-Agent: quilt/0.64 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1724 Lines: 47 4.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Charles Keepax commit 6ada5c1e1b077ab98fc144d7ac132b4dcc0148ec upstream. Commit 523c5b89640e ("i2c: Remove support for legacy PM") removed the PM ops from the bus type, which causes the pm operations on the s3c2410 adapter device to fail (-ENOSUPP in rpm_callback). The adapter device doesn't get bound to a driver and as such can't have its own pm_runtime callbacks. Previously this was fine as the bus callbacks would have been used, but now this can cause devices which use PM runtime and are attached over I2C to fail to resume. This commit fixes this issue by marking all adapter devices with pm_runtime_no_callbacks, since they can't have any. Signed-off-by: Charles Keepax Acked-by: Beata Michalska Signed-off-by: Wolfram Sang Fixes: 523c5b89640e Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/i2c-core.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -1410,6 +1410,8 @@ static int i2c_register_adapter(struct i dev_dbg(&adap->dev, "adapter [%s] registered\n", adap->name); + pm_runtime_no_callbacks(&adap->dev); + #ifdef CONFIG_I2C_COMPAT res = class_compat_create_link(i2c_adapter_compat_class, &adap->dev, adap->dev.parent); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/