Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298AbbEBWpC (ORCPT ); Sat, 2 May 2015 18:45:02 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36591 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbbEBWox (ORCPT ); Sat, 2 May 2015 18:44:53 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Samuel Thibault Subject: Re: [PATCHv7 0/2] INPUT: Route keyboard LEDs through the generic LEDs layer Date: Sun, 3 May 2015 00:44:49 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-51-generic; KDE/4.14.2; x86_64; ; ) Cc: Dmitry Torokhov , Pavel Machek , Andrew Morton , David Herrmann , Jiri Slaby , Bryan Wu , Richard Purdie , lkml , Evan Broder , Arnaud Patard , Peter Korsgaard , Sascha Hauer , Rob Clark , Niels de Vos , "linux-arm-kernel@lists.infradead.org" , blogic@openwrt.org References: <20150217191527.GA9594@type.youpi.perso.aquilenet.fr> <20150423165544.GG7646@pali> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1510334.sbYMIeaOa1"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201505030044.49464@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2994 Lines: 80 --nextPart1510334.sbYMIeaOa1 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thursday 23 April 2015 19:04:49 Dmitry Torokhov wrote: > On Thu, Apr 23, 2015 at 9:55 AM, Pali Roh=C3=A1r > wrote: > > On Thursday 02 April 2015 16:44:10 Pavel Machek wrote: > >> On Wed 2015-04-01 23:11:40, Samuel Thibault wrote: > >> > Pali Roh=C3=A1r, le Wed 01 Apr 2015 22:00:07 +0200, a =C3=A9crit : > >> > > On Tuesday 17 February 2015 20:15:27 Samuel Thibault > >> > > wrote: > >> > > > Here is an updated version to fix the initialization > >> > > > of the vt_led_work queues before registering LEDs, > >> > > > and refresh against 3.19. > >> > >=20 > >> > > Hello! I would like to ask when will be this patch > >> > > series merged into mainline kernel? Are there still > >> > > some problems with it? > >> >=20 > >> > There are no known problems ATM. > >>=20 > >> I thought it made it to -next, but apparently not. > >>=20 > >> Dmitry, can you comment what needs to be done, or just > >> merge it, please? > >>=20 > >> Pavel > >=20 > > Dmitry, can you merge this patch? >=20 > Sorry, I keep intending to go back to it and keep getting > distracted with other items. Last time I tried it it did not > appear to work for some scenarios that I tried, but I did not > document it to provide reasonable feedback to Samuel. >=20 > One thing that I know we'd have to fix is that input device > must be "opened" before we can engage it, right now LED > interface violates this requirement. It works right now > because keyboard handler attaches to most input devices with > LEDs early enough for it to be unnoticeable, but it does not > mean that it is correct. It might be as easy as calling > input_open() unconditionally if devices has LEDs. >=20 > Another issue is that I do not think we should be introducing > virtual VT leds. I believe LEDs should belong to real > devices; multiplexing several into one usually ends up with > problems (like the whole mousedev and various users having to > "grab" touchpads to exclude their data form mousedev to avoid > duplicate movement/button presses). >=20 > Hopefully I will have more coherent response RSN. >=20 > Thanks and sorry. Samuel, can you look at those issues? =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1510334.sbYMIeaOa1 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlVFU2EACgkQi/DJPQPkQ1K9mwCggkox/kIW6/wP8aFjur2QE4+f gG4AoLGP0lOyxscZsDW0y7hvtMNl0LAl =k95j -----END PGP SIGNATURE----- --nextPart1510334.sbYMIeaOa1-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/