From: KY Srinivasan <kys@microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
CC: Haiyang Zhang <haiyangz@microsoft.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dexuan Cui <decui@microsoft.com>,
        "Dan Carpenter" <dan.carpenter@oracle.com>
Subject: RE: [PATCH v2 3/3] Drivers: hv: vmbus: setup irq after synic is
 initialized
Thread-Topic: [PATCH v2 3/3] Drivers: hv: vmbus: setup irq after synic is
 initialized
Thread-Index: AQHQfE9FANQGb68zuE6FAeGljB1Ib51pjxCA
Date: Sun, 3 May 2015 01:58:47 +0000
Message-ID: <BY2PR0301MB0711D1B7FFE8BEE04BD4DD55A0D30@BY2PR0301MB0711.namprd03.prod.outlook.com>
References: <1429633298-31142-1-git-send-email-vkuznets@redhat.com>
 <1429633298-31142-4-git-send-email-vkuznets@redhat.com>
In-Reply-To: <1429633298-31142-4-git-send-email-vkuznets@redhat.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2015 01:58:47.5139
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0776
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1798
Lines: 56


> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Tuesday, April 21, 2015 9:22 AM
> To: KY Srinivasan
> Cc: Haiyang Zhang; devel@linuxdriverproject.org; linux-
> kernel@vger.kernel.org; Dexuan Cui; Dan Carpenter
> Subject: [PATCH v2 3/3] Drivers: hv: vmbus: setup irq after synic is initialized
> 
> vmbus_isr() uses synic pages which are being setup in hv_synic_alloc(), we
> need to register this irq handler only after we allocate all the required
> pages.

Why? Until we tell the hypervisor to route the vmbus interrupts on the specified vector,
no vmbus interrupts will be delivered and this is done in the function hv_synic_init().
So, the only requirement here is that all of the irq plumbing and allocations be done 
before we enable the synthetic interrupt controller and register the vector with the
hypervisor. What am I missing.

Regards,

K. Y
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
>  drivers/hv/vmbus_drv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index cf20400..e922804 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -822,11 +822,12 @@ static int vmbus_bus_init(int irq)
>  	if (ret)
>  		goto err_cleanup;
> 
> -	hv_setup_vmbus_irq(vmbus_isr);
> -
>  	ret = hv_synic_alloc();
>  	if (ret)
>  		goto err_alloc;
> +
> +	hv_setup_vmbus_irq(vmbus_isr);
> +
>  	/*
>  	 * Initialize the per-cpu interrupt state and
>  	 * connect to the host.
> --
> 1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/