Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbbECHfo (ORCPT ); Sun, 3 May 2015 03:35:44 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:37644 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbbECHfg (ORCPT ); Sun, 3 May 2015 03:35:36 -0400 MIME-Version: 1.0 In-Reply-To: <20150502211319.0d406048.akpm@linux-foundation.org> References: <20150424014545.GA9252@devel.8.8.4.4> <20150502211319.0d406048.akpm@linux-foundation.org> Date: Sun, 3 May 2015 16:35:35 +0900 Message-ID: Subject: Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error From: DaeSeok Youn To: Andrew Morton Cc: "ocfs2-devel@oss.oracle.com" , mfasheh@suse.com, linux-kernel , Richard Weinberger , Joseph Qi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 35 2015-05-03 13:13 GMT+09:00 Andrew Morton : > On Sun, 3 May 2015 12:02:39 +0900 DaeSeok Youn wrote: > >> 2015-04-24 10:45 GMT+09:00 Daeseok Youn : >> > The use of 'status' in __ocfs2_add_entry() can return wrong >> > value. Some functions' return value in __ocfs2_add_entry(), >> > i.e ocfs2_journal_access_di() is saved to 'status'. >> > But 'status' is not used in 'bail' label for returning result >> > of __ocfs2_add_entry(). >> > >> > So use retval instead of status. >> > >> > Reviewed-by: Joseph Qi >> > Signed-off-by: Daeseok Youn >> > --- >> Andrew. >> >> How is it going this patch, please check for me. > > I merged this over a week ago and it is in linux-next: > http://ozlabs.org/~akpm/mmotm/broken-out/ocfs2-use-retval-instead-of-status-for-checking-error.patch > > You were sent a commit email at the time. I missed your notification mail. Sorry. I update linux-next branch and check my commit. thanks. regards, Daeseok Youn. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/