Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751716AbbECI5M (ORCPT ); Sun, 3 May 2015 04:57:12 -0400 Received: from www.osadl.org ([62.245.132.105]:59074 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbbECI5D (ORCPT ); Sun, 3 May 2015 04:57:03 -0400 From: Nicholas Mc Guire To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH] genirq: fix unnecessary automatic type conversion Date: Sun, 3 May 2015 10:48:50 +0200 Message-Id: <1430642930-23929-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1094 Lines: 37 kstat_irqs is unsigned int and the return type of kstat_irqs() is also unsigned int so sum should be unsigned int as well even if the result is correct due to automatic type conversion. Signed-off-by: Nicholas Mc Guire --- This also helps make static code checkers happy. Patch was compile tested with x86_64_defconfig Patch is against 4.1-rc1 (localversion-next is -next-20150501) kernel/irq/irqdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c index 996ab1c..73a76e2 100644 --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -619,7 +619,7 @@ unsigned int kstat_irqs(unsigned int irq) { struct irq_desc *desc = irq_to_desc(irq); int cpu; - int sum = 0; + unsigned int sum = 0; if (!desc || !desc->kstat_irqs) return 0; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/