Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053AbbECJmg (ORCPT ); Sun, 3 May 2015 05:42:36 -0400 Received: from mail-vn0-f54.google.com ([209.85.216.54]:45124 "EHLO mail-vn0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbbECJm1 (ORCPT ); Sun, 3 May 2015 05:42:27 -0400 MIME-Version: 1.0 In-Reply-To: <20150503093953.GN12076@piout.net> References: <1429791940-22169-1-git-send-email-k.kozlowski.k@gmail.com> <20150503093953.GN12076@piout.net> Date: Sun, 3 May 2015 18:42:26 +0900 Message-ID: Subject: Re: [PATCH 1/2] rtc: interface: Fix coding style violations From: =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= To: Alexandre Belloni Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 49 2015-05-03 18:39 GMT+09:00 Alexandre Belloni : > Hi, > > On 23/04/2015 at 21:25:39 +0900, Krzysztof Kozlowski wrote : >> Fix issues reported by checkpatch: >> ERROR: open brace '{' following struct go on the same line >> ERROR: "foo* bar" should be "foo *bar" >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> include/linux/rtc.h | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/include/linux/rtc.h b/include/linux/rtc.h >> index c8b68741994e..85b48b29a143 100644 >> --- a/include/linux/rtc.h >> +++ b/include/linux/rtc.h >> @@ -101,8 +101,7 @@ struct rtc_timer { >> /* flags */ >> #define RTC_DEV_BUSY 0 >> >> -struct rtc_device >> -{ >> +struct rtc_device { >> struct device dev; >> struct module *owner; >> >> @@ -202,10 +201,10 @@ int rtc_register(rtc_task_t *task); >> int rtc_unregister(rtc_task_t *task); >> int rtc_control(rtc_task_t *t, unsigned int cmd, unsigned long arg); >> >> -void rtc_timer_init(struct rtc_timer *timer, void (*f)(void* p), void* data); >> -int rtc_timer_start(struct rtc_device *rtc, struct rtc_timer* timer, >> +void rtc_timer_init(struct rtc_timer *timer, void (*f)(void *p), void *data); >> +int rtc_timer_start(struct rtc_device *rtc, struct rtc_timer *timer, >> ktime_t expires, ktime_t period); > > While at it, alignment here should match the open parenthesis. Sure, I'll respin. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/