Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbbECOvt (ORCPT ); Sun, 3 May 2015 10:51:49 -0400 Received: from mail-vn0-f42.google.com ([209.85.216.42]:39002 "EHLO mail-vn0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbbECOvm (ORCPT ); Sun, 3 May 2015 10:51:42 -0400 MIME-Version: 1.0 In-Reply-To: <1430592980-28856-1-git-send-email-fabf@skynet.be> References: <1430592980-28856-1-git-send-email-fabf@skynet.be> Date: Sun, 3 May 2015 16:51:41 +0200 Message-ID: Subject: Re: [PATCH 1/1 linux-next] affs: add default case in switch From: Richard Weinberger To: Fabian Frederick Cc: LKML , Andrew Morton , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1724 Lines: 49 On Sat, May 2, 2015 at 8:56 PM, Fabian Frederick wrote: > Fix gcc -Wswitch-default warnings > > Cc: Andrew Morton > Signed-off-by: Fabian Frederick > --- > fs/affs/inode.c | 2 ++ > fs/affs/namei.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/fs/affs/inode.c b/fs/affs/inode.c > index 1734950..623398e 100644 > --- a/fs/affs/inode.c > +++ b/fs/affs/inode.c > @@ -143,6 +143,8 @@ struct inode *affs_iget(struct super_block *sb, unsigned long ino) > inode->i_op = &affs_symlink_inode_operations; > inode->i_data.a_ops = &affs_symlink_aops; > break; > + default: > + break; > } > > inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode->i_ctime.tv_sec > diff --git a/fs/affs/namei.c b/fs/affs/namei.c > index 181e05b..517926d 100644 > --- a/fs/affs/namei.c > +++ b/fs/affs/namei.c > @@ -237,6 +237,9 @@ affs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) > //case ST_LINKDIR: > case ST_LINKFILE: > ino = be32_to_cpu(AFFS_TAIL(sb, bh)->original); > + break; > + default: > + break; How can this code path be reached? If I read your patch correctly it just silences gcc. If the code can be reached you need to take a proper action of not the warning is bogus. -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/