Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751617AbbECTLV (ORCPT ); Sun, 3 May 2015 15:11:21 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52407 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbbECTLN (ORCPT ); Sun, 3 May 2015 15:11:13 -0400 Date: Sun, 3 May 2015 21:10:33 +0200 From: Greg KH To: Mateusz Kulikowski Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/21] staging: rtl8192e: replace memcpy() -> ether_addr_copy_unaligned() Message-ID: <20150503191033.GA12930@kroah.com> References: <1428961664-4241-1-git-send-email-mateusz.kulikowski@gmail.com> <1428961664-4241-11-git-send-email-mateusz.kulikowski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428961664-4241-11-git-send-email-mateusz.kulikowski@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 29 On Mon, Apr 13, 2015 at 11:47:33PM +0200, Mateusz Kulikowski wrote: > rtl8192e driver uses memcpy() to copy hw addresses in several places. > checkpatch.pl suggests to use ether_addr_copy(), but most of > addresses in driver may be unaligned. > This patch replaces all memcpy occurences with single macro therby > silencing checkpatch.pl (single complaints in macro remains). > > Signed-off-by: Mateusz Kulikowski > --- > drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++--- > drivers/staging/rtl8192e/rtllib.h | 3 ++ > drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 18 +++---- > drivers/staging/rtl8192e/rtllib_rx.c | 74 +++++++++++++++++----------- > drivers/staging/rtl8192e/rtllib_softmac.c | 67 +++++++++++++------------ > drivers/staging/rtl8192e/rtllib_softmac_wx.c | 5 +- > drivers/staging/rtl8192e/rtllib_tx.c | 24 ++++----- > 7 files changed, 113 insertions(+), 90 deletions(-) I've stopped applying here, no need to resend the first 9 of these patches for your next round. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/