Date: Sun, 3 May 2015 12:19:55 -0700
From: Darren Hart <dvhart@infradead.org>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] toshiba_acpi: Remove bluetooth rfkill code
Message-ID: <20150503191955.GC16105@fury.dvhart.com>
References: <1430166654-15010-1-git-send-email-coproscefalo@gmail.com>
 <1430166654-15010-2-git-send-email-coproscefalo@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1430166654-15010-2-git-send-email-coproscefalo@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1220
Lines: 35

On Mon, Apr 27, 2015 at 02:30:53PM -0600, Azael Avalos wrote:
> This patch removes all bluetooth rfkill related code residing in
> the toshiba_acpi driver.
> 
> Separate patches will add (and adapt) the code to toshiba_bluetooth
> (where it belongs).
> 
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>

Hi Azael,

With this applied the driver as build warnings:

...
  CC [M]  drivers/platform/x86/toshiba_acpi.o
drivers/platform/x86/toshiba_acpi.c: In function ‘toshiba_acpi_add’:
drivers/platform/x86/toshiba_acpi.c:2636:7: warning: unused variable ‘bt_present’ [-Wunused-variable]
  bool bt_present;
       ^
drivers/platform/x86/toshiba_acpi.c: At top level:
drivers/platform/x86/toshiba_acpi.c:358:12: warning: ‘hci_write2’ defined but not used [-Wunused-function]
 static u32 hci_write2(struct toshiba_acpi_dev *dev, u32 reg, u32 in1, u32 in2)

I presume these should be removed as well?

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/