Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751783AbbECUoO (ORCPT ); Sun, 3 May 2015 16:44:14 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751708AbbECUoB (ORCPT ); Sun, 3 May 2015 16:44:01 -0400 Message-ID: <5546888F.2050800@nod.at> Date: Sun, 03 May 2015 22:43:59 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Simon Glass CC: LKML , Doug Anderson Subject: Re: [PATCH 1/3] Add patman patch automation script References: <1430677797-20490-1-git-send-email-sjg@chromium.org> <1430677797-20490-2-git-send-email-sjg@chromium.org> <55468182.3030706@nod.at> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 32 Am 03.05.2015 um 22:40 schrieb Simon Glass: >> But I don't think it makes much sense to carry it with the Linux kernel tree. >> Other projects can also use it and it does not seem to be very Linux kernel >> specific. >> git, quilt and other great tools also have their own repositories. > > My reasoning is that: > > - more will find it / use it if it is in-tree > - it avoids installation and old-version problems (e.g. I suppose this > is why the device tree compiler is built-in) > - it is somewhat Linux-specific (e.g. uses get_maintainers, > checkpatch.pl) and can break if checkpatch.pl if the wrong version > (e.g. you check out and send patches from an older tree) > - it could be built into the Linux workflow [1] and might thereby > reduce the amount of confusion and errors (did you run checkpatch?, > your change log is in the wrong place, you forgot to add your > sign-off, etc.) If we'd follow these arguments we'd have to move the whole GNU into the kernel tree. ;-) checkpatch.pl and get_maintainers.pl are not really a show-stopper. Other projects are using them too. You can make them also configurable. i.e. check_script and get_maintaner_script. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/