Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800AbbECVoE (ORCPT ); Sun, 3 May 2015 17:44:04 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:34746 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbbECVn4 (ORCPT ); Sun, 3 May 2015 17:43:56 -0400 MIME-Version: 1.0 In-Reply-To: <5546888F.2050800@nod.at> References: <1430677797-20490-1-git-send-email-sjg@chromium.org> <1430677797-20490-2-git-send-email-sjg@chromium.org> <55468182.3030706@nod.at> <5546888F.2050800@nod.at> Date: Sun, 3 May 2015 15:43:55 -0600 X-Google-Sender-Auth: jyzM9mt-0T38HcsNTvhiiUGZTdw Message-ID: Subject: Re: [PATCH 1/3] Add patman patch automation script From: Simon Glass To: Richard Weinberger Cc: LKML , Doug Anderson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1919 Lines: 46 Hi Richard, On 3 May 2015 at 14:43, Richard Weinberger wrote: > Am 03.05.2015 um 22:40 schrieb Simon Glass: >>> But I don't think it makes much sense to carry it with the Linux kernel tree. >>> Other projects can also use it and it does not seem to be very Linux kernel >>> specific. >>> git, quilt and other great tools also have their own repositories. >> >> My reasoning is that: >> >> - more will find it / use it if it is in-tree >> - it avoids installation and old-version problems (e.g. I suppose this >> is why the device tree compiler is built-in) >> - it is somewhat Linux-specific (e.g. uses get_maintainers, >> checkpatch.pl) and can break if checkpatch.pl if the wrong version >> (e.g. you check out and send patches from an older tree) >> - it could be built into the Linux workflow [1] and might thereby >> reduce the amount of confusion and errors (did you run checkpatch?, >> your change log is in the wrong place, you forgot to add your >> sign-off, etc.) > > If we'd follow these arguments we'd have to move the whole GNU into the > kernel tree. ;-) Well maybe the first two. > checkpatch.pl and get_maintainers.pl are not really a show-stopper. > Other projects are using them too. You can make them also configurable. > i.e. check_script and get_maintaner_script. Understood, I'm just explaining my reasoning for sending this patch. With U-Boot it has been very convenient to be able to rely on this being available in the tree. 3000 lines is a drop in the ocean with Linux's 22m lines. But I fully understand your point of view. If nothing else, at least this series provides an easy way for people to try it out. Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/