Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbbEDFvo (ORCPT ); Mon, 4 May 2015 01:51:44 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:39945 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbEDFvf (ORCPT ); Mon, 4 May 2015 01:51:35 -0400 Message-ID: <554708E0.1010600@linux.vnet.ibm.com> Date: Mon, 04 May 2015 11:21:28 +0530 From: Preeti U Murthy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: tglx@linutronix.de, mingo@kernel.org CC: peterz@infradead.org, linuxppc-dev@ozlabs.org, john.stultz@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tick-broadcast: Fix the printing of broadcast masks References: <20150428084520.3314.62668.stgit@preeti.in.ibm.com> In-Reply-To: <20150428084520.3314.62668.stgit@preeti.in.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15050405-0029-0000-0000-000002910AB2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1956 Lines: 54 Ping. Any comments on this patch ? Regards Preeti U Murthy On 04/28/2015 02:15 PM, Preeti U Murthy wrote: > Today the number of bits of the broadcast masks that is output into > /proc/timer_list is sizeof(unsigned long). This means that on machines > with larger number of CPUs, the bitmasks of CPUs beyond this range do > not appear. > > Fix this by using bitmap printing through "%*pb" instead, so as to > output the broadcast masks for the range of nr_cpu_ids into > /proc/timer_list. > > Signed-off-by: Preeti U Murthy > --- > > kernel/time/timer_list.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c > index c82b03c..1afc726 100644 > --- a/kernel/time/timer_list.c > +++ b/kernel/time/timer_list.c > @@ -269,11 +269,11 @@ static void timer_list_show_tickdevices_header(struct seq_file *m) > { > #ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST > print_tickdevice(m, tick_get_broadcast_device(), -1); > - SEQ_printf(m, "tick_broadcast_mask: %08lx\n", > - cpumask_bits(tick_get_broadcast_mask())[0]); > + SEQ_printf(m, "tick_broadcast_mask: %*pb\n", > + cpumask_pr_args(tick_get_broadcast_mask())); > #ifdef CONFIG_TICK_ONESHOT > - SEQ_printf(m, "tick_broadcast_oneshot_mask: %08lx\n", > - cpumask_bits(tick_get_broadcast_oneshot_mask())[0]); > + SEQ_printf(m, "tick_broadcast_oneshot_mask: %*pb\n", > + cpumask_pr_args(tick_get_broadcast_oneshot_mask())); > #endif > SEQ_printf(m, "\n"); > #endif > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/