Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbbEDIXI (ORCPT ); Mon, 4 May 2015 04:23:08 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:50991 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbbEDIXE (ORCPT ); Mon, 4 May 2015 04:23:04 -0400 Date: Mon, 4 May 2015 11:22:50 +0300 From: Dan Carpenter To: Mitchel Humpherys Cc: devel@linuxdriverproject.org, Greg Kroah-Hartman , Android Kernel Team , Colin Cross , John Stultz , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] staging: ion: chunk_heap: use %pad for printing dma_addr_t's Message-ID: <20150504082250.GJ14154@mwanda> References: <1428628204-25752-1-git-send-email-mitchelh@codeaurora.org> <1428628204-25752-2-git-send-email-mitchelh@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428628204-25752-2-git-send-email-mitchelh@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2716 Lines: 60 On Thu, Apr 09, 2015 at 06:10:04PM -0700, Mitchel Humpherys wrote: > We're currently using %lu and %ld to print some variables of type > dma_addr_t, which results in the following warning when dma_addr_t is > 64-bits wide: > > drivers/staging/android/ion/ion_chunk_heap.c: In function 'ion_chunk_heap_create': > drivers/staging/android/ion/ion_chunk_heap.c:176:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'dma_addr_t' [-Wformat=] > pr_info("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base, > ^ > drivers/staging/android/ion/ion_chunk_heap.c:176:2: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'dma_addr_t' [-Wformat=] > > Fix this by using %pad as instructed in printk-formats.txt. > > Signed-off-by: Mitchel Humpherys This one was just merged and I was about to email you that it introduces some new Smatch warnings, but actually looking at it, it's just wrong. We want to print "chunk_heap->base" and not "&chunk_heap->base". And anyway "&chunk_heap->base" is a regular pointer, not a dma_addr_t. So please send a new patch that removes the &. regards, dan carpenter > --- > drivers/staging/android/ion/ion_chunk_heap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c > index 54746157d799..6b3e18aa1c64 100644 > --- a/drivers/staging/android/ion/ion_chunk_heap.c > +++ b/drivers/staging/android/ion/ion_chunk_heap.c > @@ -173,8 +173,8 @@ struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data) > chunk_heap->heap.ops = &chunk_heap_ops; > chunk_heap->heap.type = ION_HEAP_TYPE_CHUNK; > chunk_heap->heap.flags = ION_HEAP_FLAG_DEFER_FREE; > - pr_debug("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base, > - heap_data->size, heap_data->align); > + pr_debug("%s: base %pad size %zu align %pad\n", __func__, > + &chunk_heap->base, heap_data->size, &heap_data->align); > > return &chunk_heap->heap; > > -- > Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/