Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545AbbEDIiQ (ORCPT ); Mon, 4 May 2015 04:38:16 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36400 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751860AbbEDIiI (ORCPT ); Mon, 4 May 2015 04:38:08 -0400 Date: Mon, 4 May 2015 10:38:06 +0200 From: Michal Hocko To: Mel Gorman Cc: Andrew Morton , Nathan Zimmer , Dave Hansen , Waiman Long , Scott Norton , Daniel J Blueman , Linux-MM , LKML Subject: Re: [PATCH 06/13] mm: meminit: Inline some helper functions Message-ID: <20150504083806.GC24296@dhcp22.suse.cz> References: <1430231830-7702-1-git-send-email-mgorman@suse.de> <1430231830-7702-7-git-send-email-mgorman@suse.de> <20150504083356.GA24308@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150504083356.GA24308@dhcp22.suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 51 I have taken this into my mm git tree for now. I guess Andrew will fold it into the original patch later. --- >From 986279c465b2f513bcbb91ba7010cb2184d1bb7c Mon Sep 17 00:00:00 2001 From: Michal Hocko Date: Mon, 4 May 2015 10:35:36 +0200 Subject: [PATCH] mm-meminit-inline-some-helper-functions-fix2.patch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit mm/page_alloc.c: In function ‘deferred_init_memmap’: mm/page_alloc.c:1135:4: error: implicit declaration of function ‘meminit_pfn_in_nid’ [-Werror=implicit-function-declaration] if (!meminit_pfn_in_nid(pfn, nid, &nid_init_state)) { ^ because randconfig decided to disable CONFIG_NODES_SPAN_OTHER_NODES. Signed-off-by: Michal Hocko --- mm/page_alloc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3e0257debce0..a48128d882d8 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1044,6 +1044,11 @@ static inline bool __meminit early_pfn_in_nid(unsigned long pfn, int node) { return true; } +static inline bool __meminit meminit_pfn_in_nid(unsigned long pfn, int node, + struct mminit_pfnnid_cache *state) +{ + return true; +} #endif -- 2.1.4 -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/