Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbbEDJQd (ORCPT ); Mon, 4 May 2015 05:16:33 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54533 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbbEDJQ0 (ORCPT ); Mon, 4 May 2015 05:16:26 -0400 Date: Mon, 4 May 2015 10:16:22 +0100 From: Luis Henriques To: "Du, Changbin" Cc: "stable@vger.kernel.org" , "balbi@ti.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Cohen, David A" , "Wu, Hao" Subject: Re: [PATCH] usb: gadget: composite: enable BESL support Message-ID: <20150504091622.GC1792@ares.olymp> References: <0C18FE92A7765D4EB9EE5D38D86A563A01CDD6AE@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A01CDD6AE@SHSMSX103.ccr.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2103 Lines: 61 On Tue, Apr 28, 2015 at 07:56:13AM +0000, Du, Changbin wrote: > From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001 > From: Felipe Balbi > Date: Tue, 30 Sep 2014 16:08:03 -0500 > Subject: [PATCH] usb: gadget: composite: enable BESL support > > According to USB 2.0 ECN Errata for Link Power > Management (USB2-LPM-Errata-final.pdf), BESL > must be enabled if LPM is enabled. > > This helps with USB30CV TD 9.21 LPM L1 > Suspend Resume Test. > > Cc: # 3.14 > Signed-off-by: Felipe Balbi > Signed-off-by: Du, Changbin > --- > Hi, > > This patch was introduced on v3.18. However the issue fixed already existed on > v3.14 and v3.14 is a long term support version. > > So propose to backport it over there as well. > Thank you, I'm also queuing it for the 3.16 kernel. Cheers, -- Lu?s > Du, Changbin > --- > drivers/usb/gadget/composite.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c > index a8c18df..f6a51fd 100644 > --- a/drivers/usb/gadget/composite.c > +++ b/drivers/usb/gadget/composite.c > @@ -560,7 +560,7 @@ static int bos_desc(struct usb_composite_dev *cdev) > usb_ext->bLength = USB_DT_USB_EXT_CAP_SIZE; > usb_ext->bDescriptorType = USB_DT_DEVICE_CAPABILITY; > usb_ext->bDevCapabilityType = USB_CAP_TYPE_EXT; > - usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT); > + usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT | USB_BESL_SUPPORT); > > /* > * The Superspeed USB Capability descriptor shall be implemented by all > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/