Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752844AbbEDKaL (ORCPT ); Mon, 4 May 2015 06:30:11 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:51905 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbbEDK3e (ORCPT ); Mon, 4 May 2015 06:29:34 -0400 Message-ID: <1430735320.3722.34.camel@pengutronix.de> Subject: Re: [PATCH v7 05/15] dt-bindings: Document the STM32 reset bindings From: Philipp Zabel To: Daniel Thompson Cc: Maxime Coquelin , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Andreas =?ISO-8859-1?Q?F=E4rber?= , Geert Uytterhoeven , Rob Herring , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" , Nicolae Rosia , Kamil Lulko Date: Mon, 04 May 2015 12:28:40 +0200 In-Reply-To: <5544A069.5000808@linaro.org> References: <1430410844-16062-1-git-send-email-mcoquelin.stm32@gmail.com> <1430410844-16062-6-git-send-email-mcoquelin.stm32@gmail.com> <55433467.2010603@linaro.org> <5544A069.5000808@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1538 Lines: 44 Am Samstag, den 02.05.2015, 11:01 +0100 schrieb Daniel Thompson: > On 02/05/15 08:55, Maxime Coquelin wrote: > > 2015-05-01 10:08 GMT+02:00 Daniel Thompson : [...] > >> Do you intend the clock driver to use the same compatible string (given it > >> is the same bit of hardware). > >> > >> If so, is it better to use st,stm32f4-rcc here? It seems unlikey to me that > >> the register layout of the PLLs and dividers can be the same on the f7 parts > >> (and later). > > > > I agree we need a compatible dedicate to f4 series for clocks, and > > maybe even one for f429 (to be checked). > > For the reset part, we don't have this need. > > > > So either we use only "st,stm32f4" as you suggest, or we can have both > > in device tree: > > > > rcc: reset@40023800 { > > #reset-cells = <1>; > > compatible = "st,stm32f4-rcc", "st,stm32-rcc"; > > reg = <0x40023800 0x400>; > > }; > > > > What do you think? > > Having both makes sense. The reset driver probably doesn't care about > differences between F4 and F7 (I know very little about F7 but I can't > think of any obvious h/ware evolution that would confuse the current > reset driver). Seconded, this is exactly the way compatible string lists are supposed to be used. [...] regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/