Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752460AbbEDLMX (ORCPT ); Mon, 4 May 2015 07:12:23 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36371 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbbEDLLu (ORCPT ); Mon, 4 May 2015 07:11:50 -0400 MIME-Version: 1.0 In-Reply-To: <1430735320.3722.34.camel@pengutronix.de> References: <1430410844-16062-1-git-send-email-mcoquelin.stm32@gmail.com> <1430410844-16062-6-git-send-email-mcoquelin.stm32@gmail.com> <55433467.2010603@linaro.org> <5544A069.5000808@linaro.org> <1430735320.3722.34.camel@pengutronix.de> Date: Mon, 4 May 2015 13:11:48 +0200 Message-ID: Subject: Re: [PATCH v7 05/15] dt-bindings: Document the STM32 reset bindings From: Maxime Coquelin To: Philipp Zabel Cc: Daniel Thompson , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Linus Walleij , Arnd Bergmann , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" , Nicolae Rosia , Kamil Lulko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1904 Lines: 56 2015-05-04 12:28 GMT+02:00 Philipp Zabel : > Am Samstag, den 02.05.2015, 11:01 +0100 schrieb Daniel Thompson: >> On 02/05/15 08:55, Maxime Coquelin wrote: >> > 2015-05-01 10:08 GMT+02:00 Daniel Thompson : > [...] >> >> Do you intend the clock driver to use the same compatible string (given it >> >> is the same bit of hardware). >> >> >> >> If so, is it better to use st,stm32f4-rcc here? It seems unlikey to me that >> >> the register layout of the PLLs and dividers can be the same on the f7 parts >> >> (and later). >> > >> > I agree we need a compatible dedicate to f4 series for clocks, and >> > maybe even one for f429 (to be checked). >> > For the reset part, we don't have this need. >> > >> > So either we use only "st,stm32f4" as you suggest, or we can have both >> > in device tree: >> > >> > rcc: reset@40023800 { >> > #reset-cells = <1>; >> > compatible = "st,stm32f4-rcc", "st,stm32-rcc"; >> > reg = <0x40023800 0x400>; >> > }; >> > >> > What do you think? >> >> Having both makes sense. The reset driver probably doesn't care about >> differences between F4 and F7 (I know very little about F7 but I can't >> think of any obvious h/ware evolution that would confuse the current >> reset driver). > > Seconded, this is exactly the way compatible string lists are supposed > to be used. Ok good, so we all agree. I propose I keep "st,stm32-rcc" only for this series, as it does not contain the clock driver. The series adding the clock driver will add "st,stm32f4-rcc", or "st,stm32f429-rcc" depending on clock driver needs. Thanks, Maxime > > [...] > > regards > Philipp > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/