Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753378AbbEDNQU (ORCPT ); Mon, 4 May 2015 09:16:20 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49337 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbbEDNP6 (ORCPT ); Mon, 4 May 2015 09:15:58 -0400 Date: Mon, 4 May 2015 13:28:10 +0100 From: Mark Brown To: Krzysztof =?utf-8?Q?Koz=C5=82owski?= Cc: Axel Lin , Jaewon Kim , Beomho Seo , Liam Girdwood , "linux-kernel@vger.kernel.org" Message-ID: <20150504122810.GT15510@sirena.org.uk> References: <1430460999.4848.1.camel@ingics.com> <1430461041.4848.2.camel@ingics.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/FJxnyttrH06HRq2" Content-Disposition: inline In-Reply-To: X-Cookie: Keep refrigerated. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 86.189.253.62 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFT][PATCH 2/2] regulator: max77843: Convert to use regulator_is_enabled_regmap X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 44 --/FJxnyttrH06HRq2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 01, 2015 at 04:54:08PM +0900, Krzysztof Koz=C5=82owski wrote: > 2015-05-01 15:17 GMT+09:00 Axel Lin : > > Use regulator_is_enabled_regmap() to replace max77843_reg_is_enabled(). > I did not update the max77843 driver with such change (as did for max7769= 3) > because I think they should be merged: > https://lkml.org/lkml/2015/4/29/185 > These devices are almost the same. I can't see that link since I don't have internet access right now but surely it's going to be clearer that the code for the devices is the same if we make updates like this to both devices? Otherwise it's less obvious on review. --/FJxnyttrH06HRq2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVR2XZAAoJECTWi3JdVIfQZuAH/2J5QnmIKOFKo23ARlPy0EMu aWMx30jbiuf1Er9IXlmF5heQDffximBzQNHBBG9KU7QhDApIt0n6RfpqWVOm73tn ICisLVdtt3nH4Ms1Zv5d/eZ86PaK4z9srwUQaBku0PQjkOXYYONhehDsB9O+tAzR qMuDwr+YBzvieB43BQwsjQwhZQeWCilIx1FJBSpvhJVw66l+tMCl5IPt6/srYagc +98I93lQIagA7nbJ+DsTPPgVKB2zuAF4mP2f+JoZq6RPsyZx6u1u/6WbbM82rI1g pfYLcCxWpZmveanry51rEeuByVtjCvQhU+8EGHUMj16O0rJGOR88e2URS7xplnI= =IWjQ -----END PGP SIGNATURE----- --/FJxnyttrH06HRq2-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/