Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753448AbbEDMn5 (ORCPT ); Mon, 4 May 2015 08:43:57 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:33085 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752616AbbEDMnc (ORCPT ); Mon, 4 May 2015 08:43:32 -0400 Message-ID: <5547696D.8000300@gmail.com> Date: Mon, 04 May 2015 21:43:25 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Daniel Stone CC: Inki Dae , linux-samsung-soc , Seung-Woo Kim , Linux Kernel Mailing List , dri-devel , Kyungmin Park , Kukjin Kim , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] drm/exynos: Fix build breakage on !DRM_EXYNOS_FIMD References: <1430539706-2945-1-git-send-email-k.kozlowski.k@gmail.com> <55472339.8040408@samsung.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2728 Lines: 74 2015-05-04 20:34 GMT+09:00 Daniel Stone : > Hi, > > On 4 May 2015 at 08:43, Inki Dae wrote: >> On 2015년 05월 02일 13:08, Krzysztof Kozlowski wrote: >>> Selecting CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD leading to build >>> error: >> >> No, eDP has no any dependency of FIMD but DECON. Just add dependency >> code like below, >> >> config DRM_EXYNOS7_DECON >> bool "Exynos DRM DECON" >> - depends on DRM_EXYNOS >> + depends on DRM_EXYNOS && !FB_S3C Actually my commit message was not detailed enough. The FB_S3C here won't solve the issue because you may: 1, disable FIMD and FB_S3C, 2, enabke DECON and DP, and it won't compile. Currently the FIMD must be enabled if DRM_EXYNOS_DP is enabled. > > But it does clearly and explicitly call fimd_dp_clock_enable from > exynos_dp_powero{n,ff}. So the dependency you're proposing seems > backwards: it's not an expression of the requirements of the current > code (that FIMD DP code be available, i.e. CONFIG_DRM_EXYNOS_FIMD is > selected), but an indirect expression of another dependency > (CONFIG_FB_S3C disables CONFIG_DRM_EXYNOS_FIMD, so disable > CONFIG_FB_S3C). > > Additionally, as the call comes from exynos_dp_core.c, which is built > by CONFIG_DRM_EXYNOS_DP (an explicitly user-selectable option), why > shouldn't the dependency be there? Ah, because the dependency on DP is > for (DECON || FIMD), but as DECON doesn't provide > fimd_dp_clock_enable(), it doesn't seem like it would compile if you > selected DECON and not FIMD. > > So, for me, the cleanest solution would be config DRM_EXYNOS_DP gains > a hard dependency on DRM_EXYNOS_FIMD, at least until it can be fixed > to compile without FIMD. Right, you correctly pointed current dependencies. Still it looks little hacky because EXYNOS_DP may work with FIMD or DECON. It does not really need FIMD. Using ifdefs in headers is not uncommon - many core subsystems do this that way to provide stubs. Probably the cleanest way would be to provide by FIMD and DECON a common interface for DP for such operation, something like: struct exynos_drm_crtc { struct drm_crtc base; ... void (*clock_enable)(struct exynos_drm_crtc *crtc, bool enable) ); which, if non-NULL, will be called by exynos_dp_core.c: static void exynos_dp_poweron(struct exynos_dp_device *dp) { ... if (crtc->clock_enable) crtc->clock_enable(crtc, true); } What do you think? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/