Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 15 Jan 2003 19:12:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 15 Jan 2003 19:12:27 -0500 Received: from e35.co.us.ibm.com ([32.97.110.133]:21991 "EHLO e35.co.us.ibm.com") by vger.kernel.org with ESMTP id ; Wed, 15 Jan 2003 19:12:25 -0500 Subject: [PATCH][RESEND] linux-2.5.58_timer-tsc-cleanup_A0 From: john stultz To: Linus Torvalds Cc: lkml , Trivial Patch Monkey Content-Type: text/plain Organization: Message-Id: <1042676113.1515.129.camel@w-jstultz2.beaverton.ibm.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.1 Date: 15 Jan 2003 16:15:14 -0800 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Linus, All, This patch cleans up the timer_tsc code, removing the unused use_tsc variable and making fast_gettimeoffset_quotient static. Please apply. thanks -john diff -Nru a/arch/i386/kernel/smpboot.c b/arch/i386/kernel/smpboot.c --- a/arch/i386/kernel/smpboot.c Wed Jan 15 15:54:11 2003 +++ b/arch/i386/kernel/smpboot.c Wed Jan 15 15:54:11 2003 @@ -182,8 +182,6 @@ #define NR_LOOPS 5 -extern unsigned long fast_gettimeoffset_quotient; - /* * accurate 64-bit/32-bit division, expanded to 32-bit divisions and 64-bit * multiplication. Not terribly optimized but we need it at boot time only @@ -223,7 +221,8 @@ printk("checking TSC synchronization across %u CPUs: ", num_booting_cpus()); - one_usec = ((1<<30)/fast_gettimeoffset_quotient)*(1<<2); + /* convert from kcyc/sec to cyc/usec */ + one_usec = cpu_khz / 1000; atomic_set(&tsc_start_flag, 1); wmb(); diff -Nru a/arch/i386/kernel/timers/timer_tsc.c b/arch/i386/kernel/timers/timer_tsc.c --- a/arch/i386/kernel/timers/timer_tsc.c Wed Jan 15 15:54:11 2003 +++ b/arch/i386/kernel/timers/timer_tsc.c Wed Jan 15 15:54:11 2003 @@ -18,7 +18,6 @@ extern spinlock_t i8253_lock; -static int use_tsc; /* Number of usecs that the last interrupt was delayed */ static int delay_at_last_interrupt; @@ -29,7 +28,7 @@ * Equal to 2^32 * (1 / (clocks per usec) ). * Initialized in time_init. */ -unsigned long fast_gettimeoffset_quotient; +static unsigned long fast_gettimeoffset_quotient; static unsigned long get_offset_tsc(void) { @@ -277,7 +276,6 @@ unsigned long tsc_quotient = calibrate_tsc(); if (tsc_quotient) { fast_gettimeoffset_quotient = tsc_quotient; - use_tsc = 1; /* * We could be more selective here I suspect * and just enable this for the next intel chips ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/