Message-ID: <55477413.2020908@opensource.altera.com>
Date: Mon, 4 May 2015 08:28:51 -0500
From: Dinh Nguyen <dinguyen@opensource.altera.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
CC: <dan.j.williams@intel.com>, <dinh.linux@gmail.com>, <vinod.koul@intel.com>,
        <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: pl300: enable the clock to PL330 dma
References: <1430713734-12175-1-git-send-email-dinguyen@opensource.altera.com>
 <CAJKOXPesbU24mrXgnTtbMOWR01Ke=hpJwLomXcYEWsLEwUx_yg@mail.gmail.com>
In-Reply-To: <CAJKOXPesbU24mrXgnTtbMOWR01Ke=hpJwLomXcYEWsLEwUx_yg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1371
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: BL2FFO11OLC013.protection.gbl
X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(51704005)(479174004)(377454003)(377424004)(199003)(189002)(24454002)(122386002)(83506001)(106466001)(65816999)(87936001)(16796002)(105606002)(85426001)(19580405001)(6806004)(19580395003)(117636001)(59896002)(64126003)(46102003)(47776003)(50466002)(86362001)(4001350100001)(66066001)(2950100001)(65956001)(65806001)(99136001)(54356999)(92566002)(87266999)(50986999)(15975445007)(23676002)(62966003)(76176999)(77156002)(5001920100001)(5001960100002)(40100003)(110136002)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB152;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:ovrnspm;A:0;MX:1;PTR:InfoDomainNonexistent;LANG:en;
X-Forefront-PRVS: 05669A7924
X-OriginatorOrg: opensource.altera.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2015 13:29:03.3409
 (UTC)
X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB152
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1619
Lines: 49

Hi Krzystof,

On 5/4/15 12:30 AM, Krzysztof Kozlowski wrote:
> 2015-05-04 13:28 GMT+09:00  <dinguyen@opensource.altera.com>:
>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>>
>> Turn on the clock to the PL330 DMA if there is a clock node provided.
> 
> Why? There is no explanation in the patch for this important question - why?
> 
> Amba bus already does this and provide a wrapper function.
> Additionally that would mess up with runtime PM and clock
> enable/disable.

I don't see the clock for the DMA getting turned on at all, which is why
after the kernel has booted, the filesystem tries to open up a serial
port using DMA and the system hangs. The failure is seen here:

http://arm-soc.lixom.net/bootlogs/next/next-20150504/socfpga-arm-multi_v7_defconfig.html

This only happens with the multi_v7_defconfig, because the PL330 DMA is
getting built into the kernel, while the socfpga_defconfig does not
enable the PL330.

The DTS for the socfpga platform looks like this:

pdma: pdma@ffe01000 {
	compatible = "arm,pl330", "arm,primecell";
	reg = <0xffe01000 0x1000>;
	interrupts = <0 104 4>,
		    <0 105 4>,
		...
		#dma-cells = <1>;
		#dma-channels = <8>;
		#dma-requests = <32>;
		clocks = <&l4_main_clk>;
		clock-names = "apb_pclk";
};

Perhaps I have the wrong designation for clock-names and the amba bus is
not able to pick up the correct clock?

Dinh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/