Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752859AbbEDNwI (ORCPT ); Mon, 4 May 2015 09:52:08 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:33001 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752549AbbEDNwA (ORCPT ); Mon, 4 May 2015 09:52:00 -0400 MIME-Version: 1.0 In-Reply-To: <20150504114558.GD15510@sirena.org.uk> References: <1430697619-22773-1-git-send-email-cernekee@chromium.org> <1430697619-22773-4-git-send-email-cernekee@chromium.org> <20150504114558.GD15510@sirena.org.uk> From: Kevin Cernekee Date: Mon, 4 May 2015 06:51:32 -0700 Message-ID: Subject: Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers To: Mark Brown Cc: Liam Girdwood , Lars-Peter Clausen , dgreid@chromium.org, Andrew Bresticker , Olof Johansson , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 19 On Mon, May 4, 2015 at 4:45 AM, Mark Brown wrote: > On Sun, May 03, 2015 at 05:00:18PM -0700, Kevin Cernekee wrote: >> + if (dev->of_node) { >> + const struct of_device_id *of_id; >> + >> + of_id = of_match_device(tas571x_of_match, dev); >> + if (of_id) >> + priv->chip = of_id->data; >> + } > > Doesn't of_match_device() do the right thing with devices not registered > from DT? Not sure. What kinds of situations are you concerned about? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/