Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752744AbbEDN4q (ORCPT ); Mon, 4 May 2015 09:56:46 -0400 Received: from mail-vn0-f54.google.com ([209.85.216.54]:33767 "EHLO mail-vn0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbbEDN4h convert rfc822-to-8bit (ORCPT ); Mon, 4 May 2015 09:56:37 -0400 MIME-Version: 1.0 In-Reply-To: <20150504122810.GT15510@sirena.org.uk> References: <1430460999.4848.1.camel@ingics.com> <1430461041.4848.2.camel@ingics.com> <20150504122810.GT15510@sirena.org.uk> Date: Mon, 4 May 2015 22:56:36 +0900 Message-ID: Subject: Re: [RFT][PATCH 2/2] regulator: max77843: Convert to use regulator_is_enabled_regmap From: =?UTF-8?Q?Krzysztof_Koz=C5=82owski?= To: Mark Brown Cc: Axel Lin , Jaewon Kim , Beomho Seo , Liam Girdwood , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 26 2015-05-04 21:28 GMT+09:00 Mark Brown : > On Fri, May 01, 2015 at 04:54:08PM +0900, Krzysztof Kozłowski wrote: >> 2015-05-01 15:17 GMT+09:00 Axel Lin : > >> > Use regulator_is_enabled_regmap() to replace max77843_reg_is_enabled(). > >> I did not update the max77843 driver with such change (as did for max77693) >> because I think they should be merged: >> https://lkml.org/lkml/2015/4/29/185 >> These devices are almost the same. > > I can't see that link since I don't have internet access right now but > surely it's going to be clearer that the code for the devices is the > same if we make updates like this to both devices? Otherwise it's less > obvious on review. Yes, indeed. The patch itself looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/