Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbbEDN5v (ORCPT ); Mon, 4 May 2015 09:57:51 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49461 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252AbbEDN5o (ORCPT ); Mon, 4 May 2015 09:57:44 -0400 Date: Mon, 4 May 2015 14:57:26 +0100 From: Mark Brown To: Kevin Cernekee Cc: Liam Girdwood , Lars-Peter Clausen , dgreid@chromium.org, Andrew Bresticker , Olof Johansson , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Message-ID: <20150504135726.GB15510@sirena.org.uk> References: <1430697619-22773-1-git-send-email-cernekee@chromium.org> <1430697619-22773-4-git-send-email-cernekee@chromium.org> <20150504114558.GD15510@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Z4ZSWl3cPHKQyRxO" Content-Disposition: inline In-Reply-To: X-Cookie: Keep refrigerated. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 86.189.253.62 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V3 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1650 Lines: 46 --Z4ZSWl3cPHKQyRxO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 04, 2015 at 06:51:32AM -0700, Kevin Cernekee wrote: > On Mon, May 4, 2015 at 4:45 AM, Mark Brown wrote: > > On Sun, May 03, 2015 at 05:00:18PM -0700, Kevin Cernekee wrote: > >> + if (dev->of_node) { > >> + const struct of_device_id *of_id; > >> + > >> + of_id = of_match_device(tas571x_of_match, dev); > >> + if (of_id) > >> + priv->chip = of_id->data; > >> + } > > Doesn't of_match_device() do the right thing with devices not registered > > from DT? > Not sure. What kinds of situations are you concerned about? I'm wondering why we need to bother checking for dev->of_node before calling it. --Z4ZSWl3cPHKQyRxO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVR3rFAAoJECTWi3JdVIfQU3sH/3xpSxPuskfBeUXqWulyo4If R6lxf+zSmrIBZn2gXxzoyL19HhlSYpRCYlST5CqHwYq4fN7MOrM4SWLkToGXhYfa mYk6CZ6lMQU/cSEN8Q8ngZ5V+RsYcTf7vjRlGrJvBILXN3QfZy3WLwZ9Usol4XSc V/P3cqDN/BM6DHIbjENrK/OUt42GWmNX/2eruPPRJlM2ax5DlSF0Qggkiufds/Ee FXmpaOXUkzhF1Ocd7xzJYP1U9n5T5wccAVfQVmEp4GNpMDWRHCxyq+0NWeaien0Z Cagf0PADPnwSYFcwl1EL559UEuKwbh7/NJGh5PXiILl0e3p1kEFfycLka5UbIKM= =acyP -----END PGP SIGNATURE----- --Z4ZSWl3cPHKQyRxO-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/