Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbbEDOGG (ORCPT ); Mon, 4 May 2015 10:06:06 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:38798 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbEDOGE (ORCPT ); Mon, 4 May 2015 10:06:04 -0400 MIME-Version: 1.0 In-Reply-To: <554713DD.4020006@metafoo.de> References: <1430697619-22773-1-git-send-email-cernekee@chromium.org> <1430697619-22773-2-git-send-email-cernekee@chromium.org> <554713DD.4020006@metafoo.de> From: Kevin Cernekee Date: Mon, 4 May 2015 07:05:38 -0700 Message-ID: Subject: Re: [PATCH V3 1/4] regmap: Use regcache_mark_dirty() to indicate power loss or reset To: Lars-Peter Clausen Cc: Liam Girdwood , Mark Brown , dgreid@chromium.org, Andrew Bresticker , Olof Johansson , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 36 On Sun, May 3, 2015 at 11:38 PM, Lars-Peter Clausen wrote: >> diff --git a/drivers/base/regmap/regcache.c >> b/drivers/base/regmap/regcache.c >> index 7eb7b3b98794..63af3103d0c6 100644 >> --- a/drivers/base/regmap/regcache.c >> +++ b/drivers/base/regmap/regcache.c >> @@ -253,6 +253,9 @@ static int regcache_default_sync(struct regmap *map, >> unsigned int min, >> unsigned int max) >> { >> unsigned int reg; >> + bool no_sync_defaults = map->no_sync_defaults; >> + >> + map->no_sync_defaults = false; > > > This needs to be done at the end in regcache_sync(), the same place where > dirty is set to false. But map->cache_dirty means "any register is dirty," not "all registers are dirty." So it can only be cleared after a successful flush. If one of the writes fails and regcache_sync() has to return prematurely, we probably don't want no_sync_defaults to stay true because some of the HW registers might not match map->reg_defaults anymore. Leaving it set to true wouldn't break the current regcache_sync() implementation, but no_sync_defaults is documented as: "if set, the HW registers are known to match map->reg_defaults". Writing any register to a non-default value makes it false. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/