Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbbEDPYY (ORCPT ); Mon, 4 May 2015 11:24:24 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:57035 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbbEDPYQ (ORCPT ); Mon, 4 May 2015 11:24:16 -0400 Message-ID: <55478F1A.3000401@mm-sol.com> Date: Mon, 04 May 2015 18:24:10 +0300 From: Stanimir Varbanov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Kishon Vijay Abraham I CC: Rob Herring , Kumar Gala , Mark Rutland , Grant Likely , Bjorn Helgaas , Russell King , Arnd Bergmann , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, Mathieu Olivari , Srinivas Kandagatla Subject: Re: [PATCH v2 2/5] phy: qcom: Add Qualcomm PCIe PHY References: <1430743338-10441-1-git-send-email-svarbanov@mm-sol.com> <1430743338-10441-3-git-send-email-svarbanov@mm-sol.com> <554783CD.50708@ti.com> In-Reply-To: <554783CD.50708@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 32 On 05/04/2015 05:35 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 04 May 2015 06:12 PM, Stanimir Varbanov wrote: >> Add a PCIe PHY driver used by PCIe host controller driver >> on Qualcomm SoCs like Snapdragon 805. >> >> Signed-off-by: Stanimir Varbanov >> --- >> drivers/phy/Kconfig | 9 ++ >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-qcom-pcie.c | 291 >> +++++++++++++++++++++++++++++++++++++++++++ > > Why do you need a new PHY driver for this? Why not use the existing QCOM > PHY driver. I can see the registers used here in phy-qcom-ufs-qmp-14nm.h? I agree that on first glance there are similarities, but I'm not sure does the PHYs are the same IP blocks. Or at least they are different revisions which have too many differences. So trying to combine them will lead to more code than now. Either way I will try to understand how many the differences are. -- regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/