Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbbEDPky (ORCPT ); Mon, 4 May 2015 11:40:54 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:17154 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232AbbEDPkq (ORCPT ); Mon, 4 May 2015 11:40:46 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 04 May 2015 08:39:22 -0700 Message-ID: <554792FB.6080804@nvidia.com> Date: Mon, 4 May 2015 11:40:43 -0400 From: Rhyland Klein User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jim Lin , Peter De Schrijver CC: Mike Turquette , Stephen Warren , Stephen Boyd , Thierry Reding , Alexandre Courbot , "linux-clk@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 12/20] clk: tegra: pll: Add specialized logic for T210 References: <1430506447-29074-1-git-send-email-rklein@nvidia.com> <1430506447-29074-13-git-send-email-rklein@nvidia.com> <3e078ce64eff4ac992900523b1b67f19@HKMAIL103.nvidia.com> In-Reply-To: <3e078ce64eff4ac992900523b1b67f19@HKMAIL103.nvidia.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 26 On 5/1/2015 11:12 PM, Jim Lin wrote: > >> +static void clk_plle_tegra210_is_enabled(struct struct clk_hw *hw) { > Returned type is "int" instead of "void". > Also one "struct" only for "clk_hw *hw"? > >> + struct tegra_clk_pll *pll = to_clk_pll(hw); >> + u32 val; >> + >> + val = pll_readl_base(pll); >> + >> + return val & PLLE_BASE_ENABLE ? 1 : 0; } >> + > --nvpublic > thanks! will fix. -rhyland -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/