Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751444AbbEDQPJ (ORCPT ); Mon, 4 May 2015 12:15:09 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:33665 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbbEDQPE (ORCPT ); Mon, 4 May 2015 12:15:04 -0400 Date: Mon, 4 May 2015 12:15:00 -0400 From: Tejun Heo To: Zefan Li Cc: Mike Galbraith , LKML , Cgroups Subject: Re: [RFC][PATCH] cgroup: disallow subtree controller enable/disable while there are tasks Message-ID: <20150504161500.GC1971@htj.duckdns.org> References: <554745D1.1000206@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <554745D1.1000206@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 22 On Mon, May 04, 2015 at 06:11:29PM +0800, Zefan Li wrote: > It's not safe if we enable/disable some controllers while there are > tasks in the substree, because task migration can fail. > > For example rt bandwidth controller disallow having rt tasks in the > cgroup if no bandwidth has been allocated, which is the case when > a cgroup is just created. > > A kernel warning is triggered immediately by doing: Well, the whole thing is behind the devel flag for a reason. Let's see how we can resolve the RT case and then determine what to do. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/