Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751946AbbEDQYs (ORCPT ); Mon, 4 May 2015 12:24:48 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:59418 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbbEDQYh (ORCPT ); Mon, 4 May 2015 12:24:37 -0400 Message-ID: <55479D35.3060603@ti.com> Date: Mon, 4 May 2015 21:54:21 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: , Bjorn Helgaas , Pratyush Anand , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , , Mohit Kumar , Subject: [Query] PCIe power management with designware Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 24 Hi, I'm planning to add power management (suspend/resume) support for DRA7xx and have a query. The pci_pm_suspend_noirq callback being a bus pm_ops gets invoked late i.e after the suspend hooks of the pci devices (including the RC driver). The problem is after the 'suspend' of the RC driver, the clocks are disabled. Now pci_pm_suspend_noirq has a call to pci_save_state() which tries to access the configuration space registers. Since the clocks are disabled by now, this results in an abort. Shouldn't we do save_state() earlier? After working around the above problem, I face one more issue with broadcom BCM95721 A211 card. After resuming, I'm unable to access the memory space. I'm not sure if that is specific to that particular card, since I have no problems with USB cards. Cheers Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/