Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbbEDREk (ORCPT ); Mon, 4 May 2015 13:04:40 -0400 Received: from mailrelay106.isp.belgacom.be ([195.238.20.133]:57784 "EHLO mailrelay106.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbbEDREc (ORCPT ); Mon, 4 May 2015 13:04:32 -0400 X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=Xz9Uco7AEzg9ElRFdtKQLJViOsXK4SGQVO9ewqrYxis= c=1 sm=2 a=nIzv61c_HFogx9MKr1EA:9 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BeMwDKpUdV/+t0sFtcgwyBL4E/sjoFAYECmEIEAgKBK00BAQEBAQGBC0EFg1sBAQQnLyMQUTkeGYgvAcV1AQEBByKGF4lCZQcWhBcFnF+MR4lXI2CDFjwxgQKBQwEBAQ From: Fabian Frederick To: linux-kernel@vger.kernel.org Cc: Fabian Frederick , David Airlie , dri-devel@lists.freedesktop.org Subject: [PATCH 2/2 linux-next] drm/msm: use IS_ERR() to check regulator_get() return Date: Mon, 4 May 2015 19:03:55 +0200 Message-Id: <1430759036-17827-2-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1430759036-17827-1-git-send-email-fabf@skynet.be> References: <1430759036-17827-1-git-send-email-fabf@skynet.be> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 28 regulator_get() never returns NULL. There's no need for IS_ERR_OR_NULL() Signed-off-by: Fabian Frederick --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 956b224..642cbaf 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -273,7 +273,7 @@ static const struct dsi_config *dsi_get_config(struct msm_dsi_host *msm_host) u32 major = 0, minor = 0; gdsc_reg = regulator_get(&msm_host->pdev->dev, "gdsc"); - if (IS_ERR_OR_NULL(gdsc_reg)) { + if (IS_ERR(gdsc_reg)) { pr_err("%s: cannot get gdsc\n", __func__); goto fail; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/