Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751903AbbEDSpd (ORCPT ); Mon, 4 May 2015 14:45:33 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:33488 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbbEDSpX (ORCPT ); Mon, 4 May 2015 14:45:23 -0400 MIME-Version: 1.0 In-Reply-To: References: <1430516505-4812-1-git-send-email-aricart@memnix.com> <1430559977.5803.12.camel@memnix.com> Date: Mon, 4 May 2015 11:45:22 -0700 X-Google-Sender-Auth: c7elpDkA3hHtM_1chJ9ZWu_Lx90 Message-ID: Subject: Re: [PATCH] MODSIGN: Change default key details [ver #2] From: Linus Torvalds To: Abelardo Ricart III Cc: Michal Marek , Linux Kernel Mailing List , Sedat Dilek , David Howells , keyrings@linux-nfs.org, Rusty Russell , LSM List , James Morris , Greg Kroah-Hartman Content-Type: multipart/mixed; boundary=20cf303347bbebaded051545f6df Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2840 Lines: 61 --20cf303347bbebaded051545f6df Content-Type: text/plain; charset=UTF-8 On Sun, May 3, 2015 at 6:45 PM, Linus Torvalds wrote: > > I'd much rather see "x509.genkey" be generated with a move-if-changed > pattern, so that it only changes if (a) it didn't exist before or (b) > it actually has new content. Hmm. Something like the attached, to make the .x509.list file be properly generated? That still leaves the problem that the X509_CERTIFICATES variable itself seems to be badly defined, in that it ends up randomly having the "./" in front of the filename due to confusion between "signing_key.x509" being both in X509_CERTIFICATES-y := $(wildcard *.x509) $(wildcard $(srctree)/*.x509) (when that .x509 file was pre-existing), and X509_CERTIFICATES-$(CONFIG_MODULE_SIG) += $(objtree)/signing_key.x509 where I think that "$(objtree)/" comes in. DavidH, comments? Linus --20cf303347bbebaded051545f6df Content-Type: text/plain; charset=US-ASCII; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i9a8ltw10 IGtlcm5lbC9NYWtlZmlsZSB8IDE0ICsrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNSBp bnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2tlcm5lbC9NYWtlZmls ZSBiL2tlcm5lbC9NYWtlZmlsZQppbmRleCA2MGMzMDJjZmI0ZDMuLjIwNWJkYzJiMTFlNyAxMDA2 NDQKLS0tIGEva2VybmVsL01ha2VmaWxlCisrKyBiL2tlcm5lbC9NYWtlZmlsZQpAQCAtMTM1LDEz ICsxMzUsNiBAQCBpZmVxICgkKFg1MDlfQ0VSVElGSUNBVEVTKSwpCiAkKHdhcm5pbmcgKioqIE5v IFguNTA5IGNlcnRpZmljYXRlcyBmb3VuZCAqKiopCiBlbmRpZgogCi1pZm5lcSAoJCh3aWxkY2Fy ZCAkKG9iaikvLng1MDkubGlzdCksKQotaWZuZXEgKCQoc2hlbGwgY2F0ICQob2JqKS8ueDUwOS5s aXN0KSwkKFg1MDlfQ0VSVElGSUNBVEVTKSkKLSQoaW5mbyBYLjUwOSBjZXJ0aWZpY2F0ZSBsaXN0 IGNoYW5nZWQpCi0kKHNoZWxsIHJtICQob2JqKS8ueDUwOS5saXN0KQotZW5kaWYKLWVuZGlmCi0K IGtlcm5lbC9zeXN0ZW1fY2VydGlmaWNhdGVzLm86ICQob2JqKS94NTA5X2NlcnRpZmljYXRlX2xp c3QKIAogcXVpZXRfY21kX3g1MDljZXJ0cyAgPSBDRVJUUyAgICRACkBAIC0xNTEsOSArMTQ0LDEy IEBAIHRhcmdldHMgKz0gJChvYmopL3g1MDlfY2VydGlmaWNhdGVfbGlzdAogJChvYmopL3g1MDlf Y2VydGlmaWNhdGVfbGlzdDogJChYNTA5X0NFUlRJRklDQVRFUykgJChvYmopLy54NTA5Lmxpc3QK IAkkKGNhbGwgaWZfY2hhbmdlZCx4NTA5Y2VydHMpCiAKK2RlZmluZSBmaWxlY2hrX3g1MDlfbGlz dAorCWVjaG8gJChYNTA5X0NFUlRJRklDQVRFUykKK2VuZGVmCiB0YXJnZXRzICs9ICQob2JqKS8u eDUwOS5saXN0Ci0kKG9iaikvLng1MDkubGlzdDoKLQlAZWNobyAkKFg1MDlfQ0VSVElGSUNBVEVT KSA+JEAKKyQob2JqKS8ueDUwOS5saXN0OiBNYWtlZmlsZSBGT1JDRQorCSQoY2FsbCBmaWxlY2hr LHg1MDlfbGlzdCkKIGVuZGlmCiAKIGNsZWFuLWZpbGVzIDo9IHg1MDlfY2VydGlmaWNhdGVfbGlz dCAueDUwOS5saXN0Cg== --20cf303347bbebaded051545f6df-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/