Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751854AbbEDSvs (ORCPT ); Mon, 4 May 2015 14:51:48 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:45240 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbbEDSvk (ORCPT ); Mon, 4 May 2015 14:51:40 -0400 Date: Mon, 4 May 2015 11:51:33 -0700 From: Guenter Roeck To: Heiko Carstens Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah.kh@samsung.com, stable , Martin Schwidefsky , Rabin Vincent , Steven Rostedt Subject: Re: [PATCH 3.10 00/65] 3.10.77-stable review Message-ID: <20150504185133.GA31982@roeck-us.net> References: <20150502190114.555225285@linuxfoundation.org> <55467BDC.6000407@roeck-us.net> <5546F82B.5040009@roeck-us.net> <20150504080914.GA5159@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150504080914.GA5159@osiris> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.5547BFBC.00DD,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 3 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2871 Lines: 60 On Mon, May 04, 2015 at 10:09:14AM +0200, Heiko Carstens wrote: > On Sun, May 03, 2015 at 09:40:11PM -0700, Guenter Roeck wrote: > > On 05/03/2015 12:49 PM, Guenter Roeck wrote: > > >On 05/02/2015 12:03 PM, Greg Kroah-Hartman wrote: > > >>This is the start of the stable review cycle for the 3.10.77 release. > > >>There are 65 patches in this series, all will be posted as a response > > >>to this one. If anyone has any issues with these being applied, please > > >>let me know. > > >> > > >>Responses should be made by Mon May 4 19:00:04 UTC 2015. > > >>Anything received after that time might be too late. > > >> > > Also, for s390, similar to the error seen in 3.14: > > > > arch/s390/kernel/suspend.c: In function 'pfn_is_nosave': > > arch/s390/kernel/suspend.c:141:30: error: '_eshared' undeclared (first use in this function) > > arch/s390/kernel/suspend.c:141:30: note: each undeclared identifier is reported only once for each function it appears in > > arch/s390/kernel/suspend.c:142:28: error: '_stext' undeclared (first use in this function) > > arch/s390/kernel/suspend.c:151:10: error: 'ipl_info' undeclared (first use in this function) > > arch/s390/kernel/suspend.c:151:27: error: 'IPL_TYPE_NSS' undeclared (first use in this function) > > > > Presumably for the same reason ('s390/hibernate: fix save and restore of kernel text section'). > > Oh, crap.. for 3.10 two includes are missing within arch/s390/kernel/suspend.c: > and > > The corresponding commits are: > ipl.h: > 77e844b9644026c11c5883144540155de39af767 > "s390/hibernate: add early resume function" > (applies cleanly to 3.10, and was merged with 3.12) > > sections.h > 7f8998c7aef3ac9c5f3f2943e083dfa6302e90d0 > "nosave: consolidate __nosave_{begin,end} in " > > This one is ugly, since it touches a lot of architectures and depends on a > lot of other unrelated patches. I'd say it's easier to add an extra patch that > simply adds the missing include, hm? (or add the include to the patch) > The same as true for the build failure on 3.14, unfortunately. > > Does that make sense? > Adding the missing include file(s) to the patch seems to be an easier solution and would be a valid backport, at least in my opinion. I did a quick test. The s390:defconfig build passes after adding commit 77e844b9644026c11c5883144540155de39af767 and adding "#include " to the hibernate patch. s390:allmodconfig still fails to build for other reasons (because devm_request_threaded_irq and irq_create_mapping are not supported for s390 in 3.10), but that is a different issue. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/