Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751464AbbEDTLI (ORCPT ); Mon, 4 May 2015 15:11:08 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:18666 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbbEDTK7 (ORCPT ); Mon, 4 May 2015 15:10:59 -0400 Message-ID: <5547C430.7040105@fb.com> Date: Mon, 4 May 2015 13:10:40 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Shaohua Li , CC: Subject: Re: [PATCH] blk-mq: fix FUA request hang References: In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-05-04_04:2015-05-04,2015-05-04,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 20 On 05/01/2015 10:59 AM, Shaohua Li wrote: > When a FUA request enters its DATA stage of flush pipeline, the > request is added to mq requeue list, the request will then be added to > ctx->rq_list. blk_mq_attempt_merge() might merge the request with a bio. > Later when the request is finished the flush pipeline, the > request->__data_len is 0. Then I only saw the bio gets endio called, the > original request never finish. > > Adding REQ_FLUSH_SEQ into REQ_NOMERGE_FLAGS looks an easy fix. Thanks, applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/